Upgrade better-sqlite3 to 12.10.0 for Node 26 compatibility - #78
Open
loekvangool wants to merge 1 commit into
Open
Upgrade better-sqlite3 to 12.10.0 for Node 26 compatibility#78loekvangool wants to merge 1 commit into
loekvangool wants to merge 1 commit into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019e41b7-4838-7712-9a4a-42d2322332dd Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
better-sqlite3@12.6.2fails to compile on Node.js 26 due to V8 API breaking changes — specifically,v8::PropertyCallbackInfo<T>::This()was removed andv8::External::New/Valuesignatures changed.No prebuilt binaries exist for this combination (
target=26.0.0 runtime=node arch=x64), so it falls through tonode-gyp rebuild, which fails with:Upgrading to 12.10.0 resolves this — prebuilt binaries are available and the native code is compatible with the new V8 API.