Fix desktop glass chrome and inbox previews#793
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@codex please review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73e6ce72f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <PresenceDot | ||
| className="h-2.5 w-2.5" | ||
| status={selfPresenceStatus} | ||
| <SidebarFooter className="absolute inset-x-0 bottom-0 z-30 bg-sidebar/55 shadow-[0_-16px_40px_hsl(var(--sidebar)/0.55)] backdrop-blur-xl supports-[backdrop-filter]:bg-sidebar/45 dark:bg-sidebar/45 dark:shadow-[0_-16px_44px_rgba(0,0,0,0.42)] dark:supports-[backdrop-filter]:bg-sidebar/35"> |
There was a problem hiding this comment.
When there are unread channels below the current scroll position, MoreUnreadButton is still rendered at bottom-0 with z-10, but this newly absolute footer occupies the same bottom edge with z-30. In long channel lists the "more unread below" control is covered by the profile footer and its clicks are intercepted, so users lose the shortcut to jump to the next unread item. Offset the button above the footer or keep it in a higher/non-overlapping layer.
Useful? React with 👍 / 👎.
| <Markdown | ||
| className="inline max-w-full text-inherit" | ||
| content={item.preview} | ||
| interactive={false} |
There was a problem hiding this comment.
For inbox items whose content contains image or video markdown, this new preview path sends the full content through Markdown with interactive={false}, but the markdown renderer only disables links/mentions/message buttons; the img renderer still creates the lightbox/context-menu/video UI. Since this preview is inside the row button, media-only messages can render clickable media controls and alter the row height instead of showing a compact two-line preview. Either strip media for previews or make media rendering honor interactive={false}.
Useful? React with 👍 / 👎.
Co-authored-by: Cursor <cursoragent@cursor.com>
2 participants
Summary
Test plan
bin/pnpm --dir desktop exec biome check src/features/sidebar/ui/AppSidebar.tsxbin/pnpm --dir desktop exec biome check src/features/sidebar/ui/AppSidebar.tsx src/features/home/ui/InboxListPane.tsx src/features/home/ui/InboxDetailPane.tsx src/features/chat/ui/ChatHeader.tsx src/features/messages/ui/MessageTimeline.tsx src/features/messages/ui/MessageComposer.tsx src/features/messages/ui/MessageThreadPanel.tsx src/features/channels/ui/AgentSessionThreadPanel.tsx src/shared/ui/markdown.tsxMade with Cursor