fix(desktop): add top padding to forum view to clear overlay header#758
Merged
Conversation
ChatHeader uses overlaysContent (-mb-[44px]) so screens must add pt-11 to sit below it. ForumView was missing this, which made forum posts collide with the header. Matches the pattern used by every other screen (WorkflowDetailPanel, MessageThreadPanel, UserProfilePanel, etc.). Signed-off-by: Wes <wesbillman@users.noreply.github.com>
kalvinnchau
approved these changes
May 27, 2026
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forum posts were colliding with the channel header because
ForumView's root container had no top padding, whileChatHeaderis rendered withoverlaysContent(-mb-[44px]) and expects consumers to leave room.Fix
Add
pt-11to theForumViewroot, matching the convention used everywhere elseChatHeaderoverlays content (WorkflowDetailPanel,MessageThreadPanel,UserProfilePanel,AgentSessionThreadPanel).Diff
One-line change. Pre-commit + pre-push hooks all green (rust-fmt, biome, desktop/web/mobile checks, builds, clippy, tests).