fix(desktop): resolve unarchive revert and stale member list bugs#558
Merged
Conversation
Remove the onSettled refetch from useUnarchiveChannelMutation to prevent a race condition where the relay returns stale archived metadata before processing the unarchive event, overwriting the optimistic update. Invalidate the channel members query cache when membership system messages (member_joined, member_left, member_removed) arrive via the channel subscription, so the member list updates in real-time without requiring a reload. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onSettledcallback fromuseUnarchiveChannelMutationthat was eagerly invalidating channel state, causing a stale refetch to overwrite the optimisticarchivedAt: nullupdate. TheonSuccesshandler already sets the correct state.member_joined,member_left, ormember_removedpayload arrives via the channel subscription, we now invalidate the members query cache and the channels list so the UI reflects membership changes immediately.Files changed
desktop/src/features/channels/hooks.ts— removed 3-lineonSettledcallbackdesktop/src/features/messages/hooks.ts— addedKIND_SYSTEM_MESSAGEimport + 21 lines of membership cache invalidation logicTest plan
pnpm typecheckpasses clean🤖 Generated with Claude Code