Skip to content

fix(desktop): allow in-channel relay agents in mention autocomplete #4047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EliteSystemsAI wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(desktop): allow in-channel relay agents in mention autocomplete #4047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion desktop/src/features/agents/lib/agentAutocompleteEligibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,12 @@ export function getMentionableAgentPubkeys({
}

export function isAgentIdentityInManagedList(
candidate: { isAgent?: boolean; pubkey: string },
candidate: { isAgent?: boolean; isMember?: boolean; pubkey: string },
managedAgentPubkeys: ReadonlySet<string>,
) {
return (
candidate.isAgent !== true ||
candidate.isMember === true ||
managedAgentPubkeys.has(normalizePubkey(candidate.pubkey))
);
}
Expand Down
15 changes: 15 additions & 0 deletions desktop/tests/e2e/mentions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { expect, test } from "@playwright/test";

import { isAgentIdentityInManagedList } from "../../src/features/agents/lib/agentAutocompleteEligibility";

import {
installMockBridge,
openChannelBrowser,
Expand Down Expand Up @@ -36,6 +38,19 @@ const DM_THREAD_AGENT_MENTION_ERROR_TEXT =
const DM_THREAD_MEMBERS_LOADING_ERROR_TEXT =
"Checking conversation members. Try again in a moment.";

test("in-channel relay agents pass autocomplete eligibility without a local management record", () => {
expect(
isAgentIdentityInManagedList(
{
pubkey: ALLOWLIST_RELAY_AGENT_PUBKEY,
isAgent: true,
isMember: true,
},
new Set(),
),
).toBe(true);
});

/** Locator scoped to the mention autocomplete dropdown inside the composer. */
function autocomplete(page: import("@playwright/test").Page) {
return page
Expand Down