Skip to content

fix(desktop): resolve mentions from channel members [issue:#3204] #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tcballard wants to merge 2 commits into
base: main
Choose a base branch
from
+44 −5
Open

fix(desktop): resolve mentions from channel members [issue:#3204] #3906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
375f19b
fix(desktop): resolve mentions from channel members [issue:#3204]
tcballard Jul 31, 2026
ba6650a
test(desktop): cover mention allowlist visibility [issue:#3204]
tcballard Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions desktop/src/features/messages/lib/useMentions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
coalesceAutocompleteCandidatesByKey,
getMentionableAgentPubkeys,
getSharedChannelIds,
isAgentIdentityInManagedList,
shouldHideAgentFromMentions,
} from "@/features/agents/lib/agentAutocompleteEligibility";
import {
Expand Down Expand Up @@ -246,9 +245,6 @@ export function useMentions(
if (isArchivedDiscovery(pubkey)) {
return;
}
if (!isAgentIdentityInManagedList(candidate, managedAgentPubkeys)) {
return;
}
if (
shouldHideAgentFromMentions({
isAgent: candidate.isAgent === true,
Expand Down Expand Up @@ -420,7 +416,6 @@ export function useMentions(
managedAgentNamesByPubkey,
managedAgentPersonaIds,
managedAgentPersonaIdsByPubkey,
managedAgentPubkeys,
managedAgentsQuery.data,
memberPubkeys,
members,
Expand Down
44 changes: 44 additions & 0 deletions desktop/tests/e2e/mentions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,50 @@ test("@ trigger prioritizes channel members before runnable personas and other m
expect(fizzIndex).toBeLessThan(charlieIndex);
});

test("@ includes channel-member agents that are not locally managed", async ({
page,
}) => {
await installMockBridge(page);
await page.goto("/");
await page.getByTestId("channel-general").click();
await expect(page.getByTestId("chat-title")).toHaveText("general");

const input = page.getByTestId("message-input");
await input.fill("@mi");

const row = autocomplete(page).locator("button", { hasText: "mira" });
await expect(row).toBeVisible();
await expect(row.getByTestId("mention-agent-icon")).toBeVisible();
await expect(row.getByText("not in channel")).toHaveCount(0);
});

test("@ hides channel-member agents when the viewer is outside their allowlist", async ({
page,
}) => {
await installMockBridge(page, {
relayAgents: [
{
pubkey: PROFILE_ONLY_AGENT_PUBKEY,
name: "mira",
channelNames: ["general"],
respondTo: "allowlist",
respondToAllowlist: [TEST_IDENTITIES.alice.pubkey],
},
],
});
await page.goto("/");
await page.getByTestId("channel-general").click();
await expect(page.getByTestId("chat-title")).toHaveText("general");

const input = page.getByTestId("message-input");
await input.fill("@mi");

await expect(autocomplete(page)).not.toBeVisible();
await expect(
page.getByTestId(`mention-suggestion-${PROFILE_ONLY_AGENT_PUBKEY}`),
).toHaveCount(0);
});

test("thread autocomplete keeps multiple long names readable in a narrow panel", async ({
page,
}) => {
Expand Down