fix(agents): delete provider-backed instances without persona cascade - #3901
Open
Chessing234 wants to merge 2 commits into
Open
fix(agents): delete provider-backed instances without persona cascade#3901Chessing234 wants to merge 2 commits into
Chessing234 wants to merge 2 commits into
Conversation
Add helpers so delete flows can tell live remote deployments apart from persona-only records before choosing instance vs persona deletion. Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Agents library Delete on a provider-backed instance now calls the managed agent delete path instead of persona cascade deletion that the backend refuses for live remote deployments. Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@tlongwell-block @wesbillman @wpfleger96 mind taking a look when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deleteManagedAgentWithRuleswhen the primary linked instance is provider-deployed, instead of persona cascade deletion that fails with "delete those agent instances first".Fixes #3771
Test plan
pnpm test -- src/features/agents/lib/managedAgentControlActions.test.mjsMade with Cursor