fix(mobile): allow stalled composer uploads to be cancelled - #3892
Open
Chessing234 wants to merge 3 commits into
Open
fix(mobile): allow stalled composer uploads to be cancelled#3892Chessing234 wants to merge 3 commits into
Chessing234 wants to merge 3 commits into
Conversation
Give each in-flight media PUT its own HTTP client so cancelActiveUploads() can abort stalled requests, and cap image/file/video uploads with explicit timeouts that surface actionable copy instead of hanging forever. Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Expose a cancel action on the upload progress tile, let users dismiss failed upload copy, and keep cancellation silent while surfacing timeout errors. Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Add an injectable upload HTTP client factory for tests and assert cancel and timeout paths surface the dedicated recovery exceptions. Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3764 (recovery UX; does not claim to fix the reported 401 root cause).
Test plan
flutter test test/shared/relay/media_upload_test.dart --name "upload cancellation"Made with Cursor