fix(acp): acknowledge consumed owner commands in channel - #3877
Open
tcballard wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tom Ballard <tom@armytage.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the acknowledgement-only slice of #3711, as part of the ordered workstream tracked by #3863.
Adds:
!cancel,!rotate, or!shutdown;No desktop UI changed, so no screenshots are included.
Scope
Included
!cancelpublishes eitherCancelled the current turn.orNothing to cancel — no turn in flight.!rotatepublishes the active-turn, cached-idle, or empty-session acknowledgement defined in Owner control commands are invisible in the chat: no command affordance, and the outcome is only logged #3711.!shutdownpublishesShutting down.before the shutdown signal is sent.Excluded
/bountylogic.Product / Architecture Decisions
post_failure_noticetopost_notice.ThreadTagsand kind-9 channel-notice path used by failure notices and the owner!modelacknowledgement path.User-Facing Contract
!rotateCancelled the current turn — the next one starts from a fresh session.!rotateSession rotated — the next turn starts fresh.!rotateNo session to rotate — the next turn already starts fresh.!cancelCancelled the current turn.!cancelNothing to cancel — no turn in flight.!shutdownShutting down.Verification
Ran
cargo test -p buzz-acp owner_control_command_tests— 6 passed.rustfmt --edition 2021 crates/buzz-acp/src/lib.rs crates/buzz-acp/src/pool.rs --check— passed.cargo clippy -p buzz-acp --all-targets -- -D warnings— passed../scripts/run-tests.sh unit—buzz-core(237 passed) andbuzz-auth(45 passed) completed before the broader run was stopped during a localbuzz-clicompile stall.Not completed locally
just fmt-check/just clippy/just test-unit/just cisequence was not completed because the first-run workspace formatter/toolchain stalled in the local environment. The focused ACP gates above passed; CI should provide the full repository gate.Covered
!cancel.!rotate.!shutdownacknowledgement.Review Path
crates/buzz-acp/src/pool.rsnotice helper generalization.crates/buzz-acp/src/lib.rsowner-command acknowledgement sequencing.Notes For Reviewer
This is intentionally the smallest channel-notice contribution for #3711 and the first ordered contribution in #3863. Command-palette/autocomplete presentation remains deferred to its separate UI work. No desktop UI changed, and no OEXL-specific code or settlement semantics were added.