fix(compose): allow overriding S3 endpoint - #3865
Open
pollychen-lab wants to merge 1 commit into
Open
Conversation
pollychen-lab
force-pushed
the
agent/compose-s3-endpoint-env
branch
from
July 31, 2026 06:35
d84cbbe to
09400a8
Compare
Contributor
|
looks right for #3794. tiny nit: call out in the readme that path vs virtual still matters for minio vs real s3 so people dont copy the default blindly |
Contributor
|
s3 endpoint override was overdue. worth a one-line note in .env.example so people know the compose hardcode is gone. |
6 tasks
Signed-off-by: Polly Labs <pollychen.lab@gmail.com>
pollychen-lab
force-pushed
the
agent/compose-s3-endpoint-env
branch
from
July 31, 2026 12:37
09400a8 to
8cbbd53
Compare
Author
|
@Chessing234 thank you for checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUZZ_S3_ENDPOINTfrom compose.env, defaulting to bundled MinIO.BUZZ_S3_ADDRESSING_STYLEfrom.env, defaulting topathfor bundled MinIO.Fixes #3794
Validation
git diff --checkdocker compose --env-file .env configwith.envcopied from.env.examplerendersBUZZ_S3_ENDPOINT: http://minio:9000andBUZZ_S3_ADDRESSING_STYLE: path.BUZZ_S3_ENDPOINT=https://example.r2.cloudflarestorage.com BUZZ_S3_ADDRESSING_STYLE=virtual docker compose --env-file .env configrenders the external endpoint andvirtualaddressing.