fix(acp): default empty omp args to ACP mode to fix initialize timeout - #3793
Closed
bradhallett wants to merge 1 commit into
Closed
fix(acp): default empty omp args to ACP mode to fix initialize timeout#3793bradhallett wants to merge 1 commit into
bradhallett wants to merge 1 commit into
Conversation
An `omp` command launched through buzz-acp with empty or absent agent_args started omp's interactive mode instead of `omp acp`, so the ACP initialize request never received a response and Buzz reported a breaking "agent initialize failed: Request timeout". Map the normalized command identity `omp` to default args ["acp"] (matching `goose`), so empty or absent args launch ACP mode. Explicit non-empty args are preserved unchanged. Adds coverage for bare `omp` and an absolute path. Tested: cargo test -p buzz-acp (637 passed); verified the bundled buzz-acp spawns `omp acp` and returns ACP auth methods under an empty-args launch. Signed-off-by: Brad Hallett <53977268+bradhallett@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buzz-acp'sdefault_agent_argsdid not recognize theomp(Oh My Pi) command, so a managed agent configured with commandompand empty/absentagent_argslaunched omp's interactive mode instead ofomp acp. The ACPinitializerequest then never received a response, and Buzz reported a breakingagent initialize failed: Request timeout.Fix: map the normalized command identity
ompto default args["acp"](matchinggoose), so empty or absent args launch ACP mode. Explicit non-empty args are preserved unchanged. Single-file change incrates/buzz-acp/src/config.rs.Related issue
None found.
Testing
cargo test -p buzz-acp— 637 passed; addednormalizes_goose_and_omp_args_to_acpcovering bareompand an absolute path with empty args.cargo fmt --all -- --check— clean.buzz-acpspawnsomp acpand returns ACP auth methods under an empty-args launch (previously timed out).Note: local
cargo clippy --workspaceflags pre-existingclippy::question_marklints inbuzz-acp/src/{queue.rs,lib.rs}andbuzz-agentunder the newer local toolchain (clippy 1.97.0 vs the pinned 1.88); these are unrelated to this change and out of scope.