Skip to content

fix(acp): default empty omp args to ACP mode to fix initialize timeout - #3793

Closed
bradhallett wants to merge 1 commit into
block:mainfrom
bradhallett:fix/omp-acp-default-args
Closed

fix(acp): default empty omp args to ACP mode to fix initialize timeout#3793
bradhallett wants to merge 1 commit into
block:mainfrom
bradhallett:fix/omp-acp-default-args

Conversation

@bradhallett

Copy link
Copy Markdown

Summary

buzz-acp's default_agent_args did not recognize the omp (Oh My Pi) command, so a managed agent configured with command omp and empty/absent agent_args launched omp's interactive mode instead of omp acp. The ACP initialize request then never received a response, and Buzz reported a breaking agent initialize failed: Request timeout.

Fix: map the normalized command identity omp to default args ["acp"] (matching goose), so empty or absent args launch ACP mode. Explicit non-empty args are preserved unchanged. Single-file change in crates/buzz-acp/src/config.rs.

Related issue

None found.

Testing

  • cargo test -p buzz-acp — 637 passed; added normalizes_goose_and_omp_args_to_acp covering bare omp and an absolute path with empty args.
  • cargo fmt --all -- --check — clean.
  • Built the desktop app and verified the bundled buzz-acp spawns omp acp and returns ACP auth methods under an empty-args launch (previously timed out).

Note: local cargo clippy --workspace flags pre-existing clippy::question_mark lints in buzz-acp/src/{queue.rs,lib.rs} and buzz-agent under the newer local toolchain (clippy 1.97.0 vs the pinned 1.88); these are unrelated to this change and out of scope.

An `omp` command launched through buzz-acp with empty or absent agent_args started omp's interactive mode instead of `omp acp`, so the ACP initialize request never received a response and Buzz reported a breaking "agent initialize failed: Request timeout".

Map the normalized command identity `omp` to default args ["acp"] (matching `goose`), so empty or absent args launch ACP mode. Explicit non-empty args are preserved unchanged. Adds coverage for bare `omp` and an absolute path.

Tested: cargo test -p buzz-acp (637 passed); verified the bundled buzz-acp spawns `omp acp` and returns ACP auth methods under an empty-args launch.
Signed-off-by: Brad Hallett <53977268+bradhallett@users.noreply.github.com>
@bradhallett
bradhallett requested a review from a team as a code owner July 30, 2026 19:31
@bradhallett

Copy link
Copy Markdown
Author

Closing in favor of #3804, which generalizes the fix to all affected ACP runtimes (omp/grok/opencode/kimi/cursor/openclaw) at the desktop layer — deriving per-runtime launch args from the single-source PRESET_HARNESSES table rather than mirroring them into buzz-acp. See #3804.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant