test(buzz-acp): quote the steer capture path for bash - #3733
Open
sumit-m wants to merge 1 commit into
Open
Conversation
The capture path was interpolated unquoted into a bash -c script, so on Windows bash ate the backslashes as escapes: the redirect wrote a mangled relative file into the crate directory and both steer tests failed on the missing capture. Render with forward slashes and quote the redirect target. Signed-off-by: sumit-m <33051892+sumit-m@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
spawn_steer_capture_scriptinterpolates the capture path unquoted into abash -cscript:Unquoted, bash consumes the backslashes as escapes, so the redirect target collapses to the relative
C:UsersmeAppDataLocalTempbuzz-acp-steer-captureacp_shape.json. Two consequences on Windows:acp_steer_request_omits_expected_run_id_and_carries_session_and_promptandgoose_transport_wins_when_both_run_id_and_capability_presentfail, becauserun_one_steerreads the intended path and finds nothing.crates/buzz-acp/with junk files namedC:UsersmeAppData…json.Change
New
bash_pathtest helper renders the path with forward slashes — accepted by the MSYS bash used on Windows — and the redirect target is quoted so spaces are covered too. Test-only; no production code touched.Result
On Windows,
cargo test -p buzz-acpgoes from 3 failures to 1, and no stray files are left behind. The remaining failure iskeepalive_resets_idle_past_deadline, an unrelated timing flake that passes in isolation and is not addressed here.