docs: fix evalexpr string literal examples in ARCHITECTURE.md - #3723
Open
CryptoJones wants to merge 1 commit into
Open
docs: fix evalexpr string literal examples in ARCHITECTURE.md#3723CryptoJones wants to merge 1 commit into
CryptoJones wants to merge 1 commit into
Conversation
Issue block#3120 reports that the workflow filter/if examples in ARCHITECTURE.md use single-quoted evalexpr string literals ('P1', 'production'), which evalexpr 11 parses as unbound variable identifiers (VariableIdentifierNotFound), causing conditions to error silently before custom functions are reached. - Change single quotes to escaped double quotes in the two examples - Add a note that evalexpr string literals require double quotes Fixes block#3120 Co-authored-by: Aaron K. Clark (CryptoJones) <cryptojones@owasp.org> Signed-off-by: Aaron K. Clark (CryptoJones) <cryptojones@owasp.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3120.
The workflow filter/if examples in ARCHITECTURE.md use single-quoted evalexpr string literals ('P1', 'production'), which evalexpr 11 parses as unbound variable identifiers (VariableIdentifierNotFound), causing conditions to error silently before custom functions are reached.
Changes:
Verified: YAML code blocks still parse correctly with Python yaml.safe_load.
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/