fix(workflow): separate owner attribution from mentions - #3716
Open
skyerus wants to merge 1 commit into
Open
Conversation
Workflow ownership is provenance, but p tags also trigger notifications and agent wake-up. Use Buzz's relay-trusted actor tag for the owner so only explicit textual mentions become notification recipients. Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: Skye Gill <gill.skye95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3638.
What changed
actortag for workflow-owner attributionptags for members explicitly mentioned in message contentactor+p)Why
Workflow ownership is provenance, while
ptags are notification recipients and agent wake targets. Using the owner as an implicitprecipient caused every workflow-generated card to notify or wake its owner even when the rendered message contained no mention.Buzz already has the right native primitive: relay-signed delegated events use
actorfor attribution, and Desktop resolves that actor as the effective author. This change uses that existing path rather than introducing a new tag or workflow option.Verification
cargo fmt --all -- --checkcargo test -p buzz-relay --lib workflow_sink— 19 passed, 1 ignoredcargo test -p buzz-relay --lib workflow_send_message_separates_actor_from_mentioned_member -- --ignored --nocapture— passed against PostgreSQLcargo test -p buzz-workflow— 153 passed, 2 ignored