fix(dev): add .exe to Windows sidecar stub paths - #3540
Conversation
edb1dc4 to
3e7e7ee
Compare
Chessing234
left a comment
There was a problem hiding this comment.
Small and correct — Tauri's Windows externalBin lookup really does want the .exe suffix on the host triple, and leaving EXT empty elsewhere keeps this a no-op on unix. One thing worth a follow-up (not blocking): _ensure-sidecar-stubs still touches empty stubs, so a first just desktop on a clean Windows clone will get past validation and then fail later when the real binaries aren't built. Out of scope for this PR, but related to the same Windows stub path.
Chessing234
left a comment
There was a problem hiding this comment.
Approving the sidecar stub fix — minimal, correct, and unblocks every Windows recipe.
Chessing234
left a comment
There was a problem hiding this comment.
Approving the Windows sidecar stub extension fix — minimal and unblocks desktop recipes.
Tauri's externalBin validation expects binaries/<bin>-<triple>.exe on Windows, so every recipe depending on _ensure-sidecar-stubs fails there. Fixes block#2492 Signed-off-by: sumit-m <33051892+sumit-m@users.noreply.github.com>
3e7e7ee to
21df5cf
Compare
Summary
Appends
.exeto the sidecar stub filenames on Windows so_ensure-sidecar-stubsproduces the names Tauri'sexternalBinvalidation expects.On Windows the host triple is
x86_64-pc-windows-msvcand Tauri looks forbinaries/<bin>-x86_64-pc-windows-msvc.exe. The recipe creates the stubs without the suffix, so Tauri rejects them and every recipe depending on_ensure-sidecar-stubs—dev,desktop,desktop-standalone,desktop-staging— fails before the app starts.Three lines, and a no-op on every other platform:
EXTstays empty unless the triple containswindows.Related issue
Fixes #2492.
Two open PRs touch the same recipe, and I have not seen a maintainer signal which should land first:
.exefix, bundled with a managed-Node install and an onboarding scroll fix. It is currentlyCONFLICTINGand has been unreviewed since 2026-07-27. This PR isolates just the.exechange so it can be reviewed on its own; if fix(desktop): Windows sidecar stubs, managed Node, onboarding scroll #2496 is preferred, close this one.os error 13). It keeps the extensionless name, so it does not fix Windows and would conflict textually with this change. Whichever merges first, the other is a small rebase — happy to do that on this branch.Testing
Verified on Windows 11 (
x86_64-pc-windows-msvc, Git Bash):Before this change the same command produced extensionless files and
just devaborted withbinaries\buzz-acp-x86_64-pc-windows-msvc.exe doesn't exist.Not verified on macOS or Linux — I have no such hardware. The guard is
[[ "$TARGET" == *windows* ]], soEXTis empty and the emitted paths are byte-identical to today's on any non-Windows triple.