fix(dev): launch Vite through its Node entry point on Windows - #3534
Open
sumit-m wants to merge 1 commit into
Open
fix(dev): launch Vite through its Node entry point on Windows#3534sumit-m wants to merge 1 commit into
sumit-m wants to merge 1 commit into
Conversation
sumit-m
force-pushed
the
windows-dev-launch
branch
2 times, most recently
from
July 29, 2026 14:52
61860ee to
9b10dd4
Compare
Chessing234
reviewed
Jul 29, 2026
Chessing234
left a comment
Contributor
There was a problem hiding this comment.
Practical Windows fix — cmd /C can't exec the extensionless Vite shim, and node ./node_modules/vite/bin/vite.js is the portable entry point. Keeping exec on unix preserves Tauri's Ctrl-C process-group behavior. LGTM.
Chessing234
approved these changes
Jul 29, 2026
Chessing234
left a comment
Contributor
There was a problem hiding this comment.
Approving the Windows Vite Node entry-point fix.
Tauri runs beforeDevCommand through cmd /C on Windows, which has no exec and cannot execute the extensionless .bin/vite shim, so just dev fails before the app starts. Vite's Node entry point is portable; exec is kept elsewhere so Tauri's Ctrl+C still reaches Vite directly. Complements block#3515, which fixes the same launch for tauri.conf.json but not for the instance-env.sh path that just dev uses. Signed-off-by: sumit-m <33051892+sumit-m@users.noreply.github.com>
sumit-m
force-pushed
the
windows-dev-launch
branch
from
July 31, 2026 20:03
9b10dd4 to
b2f878c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Launches Vite through its Node entry point in
scripts/instance-env.sh, sojust devstarts on Windows.Tauri runs
beforeDevCommandthroughcmd /Con Windows, which has noexecbuiltin and cannot execute the extensionless./node_modules/.bin/viteshim (onlyvite.CMD/vite.ps1are executable there).just devtherefore fails before the app window ever appears.node ./node_modules/vite/bin/vite.jsis portable, andexecis kept on every other platform so Tauri's Ctrl+C still reaches Vite directly rather than leaving it parented to the shell.Both
BUZZ_TAURI_CONFIGassignments are covered — the plain one and the worktree variant.Related issue
Part of #2388 (Windows Support).
Complements #3515, which applies the same Node entry point to
desktop/src-tauri/tauri.conf.json. The two do not overlap, and either can merge first.Worth flagging for reviewers of both PRs: the four recipes that start Tauri (
Justfilelines 472, 501, 528, 555) all pass--config "$BUZZ_TAURI_CONFIG", and that merged override carries its ownbeforeDevCommandbuilt here ininstance-env.sh. It therefore wins over the value intauri.conf.json, so #3515 alone does not unblock those recipes on Windows — this change is what does. #3515 covers a barepnpm tauri devinvocation, which readstauri.conf.jsondirectly.(#3515's description mentions
just desktop-dev; that recipe runspnpm exec vitedirectly without invoking Tauri, so it never readsbeforeDevCommandand is unaffected on either side.)Testing
Verified on Windows 11 (Git Bash,
MINGW64_NT-10.0):node ./node_modules/vite/bin/vite.js --versionfromdesktop/→vite/8.0.16 win32-x64 node-v24.15.0just devreaches the running desktop app; before this change it exited during startup.BUZZ_TEST_PLATFORMoverride —Darwinyields theexecform,MINGW64_NT-10.0yields the bare form.bash -n scripts/instance-env.shclean.Not verified: signal delivery on macOS/Linux is unchanged by inspection (
execretained), but I have no Apple or Linux hardware to confirm Ctrl+C behaviour end to end.