Skip to content

fix(desktop): allow mentioning invocable external relay agents #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scoop wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(desktop): allow mentioning invocable external relay agents #3472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion desktop/src/features/agents/lib/agentAutocompleteEligibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,16 @@ export function getMentionableAgentPubkeys({
export function isAgentIdentityInManagedList(
candidate: { isAgent?: boolean; pubkey: string },
managedAgentPubkeys: ReadonlySet<string>,
mentionableAgentPubkeys?: ReadonlySet<string>,
) {
const pubkey = normalizePubkey(candidate.pubkey);
return (
candidate.isAgent !== true ||
managedAgentPubkeys.has(normalizePubkey(candidate.pubkey))
managedAgentPubkeys.has(pubkey) ||
// Externally-hosted agents (relay directory, kind:10100) that are
// invocable for the current user are legitimate mention targets even
// though no local managed-agent record exists for them.
(mentionableAgentPubkeys?.has(pubkey) ?? false)
);
}

Expand Down
8 changes: 7 additions & 1 deletion desktop/src/features/messages/lib/useMentions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,13 @@ export function useMentions(
if (isArchivedDiscovery(pubkey)) {
return;
}
if (!isAgentIdentityInManagedList(candidate, managedAgentPubkeys)) {
if (
!isAgentIdentityInManagedList(
candidate,
managedAgentPubkeys,
mentionableAgentPubkeys,
)
) {
return;
}
if (
Expand Down