Skip to content

fix(desktop): remove Projects overview card fills #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomaspblock merged 1 commit into from
Jul 30, 2026
+40 −3
Merged

fix(desktop): remove Projects overview card fills #3416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion desktop/src/features/projects/ui/ProjectsActivityFeed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,9 +257,10 @@ function ActivityCard({
return (
<div
className={cn(
"relative block w-full rounded-xl border border-border/60 bg-card text-left transition-colors hover:bg-muted/20",
"relative block w-full rounded-xl border border-border/60 bg-transparent text-left transition-colors hover:bg-muted/20",
compact ? "p-3" : "p-4",
)}
data-testid="projects-activity-card"
>
<button
aria-label={`Open ${item.title} in ${item.target.project.name}`}
Expand Down
5 changes: 3 additions & 2 deletions desktop/src/features/projects/ui/ProjectsOverviewPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ function StatPill({
}) {
return (
<button
className="flex flex-col rounded-lg border border-border/60 bg-card px-3.5 py-3 text-left transition-colors hover:bg-muted/30"
className="flex flex-col rounded-lg border border-border/60 bg-transparent px-3.5 py-3 text-left transition-colors hover:bg-muted/30"
data-testid="projects-overview-stat"
onClick={onClick}
type="button"
>
Expand Down Expand Up @@ -78,7 +79,7 @@ export function ProjectsOverviewPanel({
const stats = overviewStats(projects, summaries);

return (
<section className="-mx-4 mb-4 bg-card">
<section className="-mx-4 mb-4" data-testid="projects-overview-panel">
<div className="grid xl:grid-cols-[minmax(0,1fr)_18rem] 2xl:grid-cols-[minmax(0,1fr)_24rem]">
<div className="order-1 grid grid-cols-2 gap-2 p-4 pt-0 sm:gap-3 xl:order-none xl:col-start-1 xl:row-start-1 xl:grid-cols-4">
<StatPill
Expand Down
35 changes: 35 additions & 0 deletions desktop/tests/e2e/project-pr-review.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,41 @@ test("project overview reports aggregate work-item failures", async ({
);
});

test("project overview does not paint a background behind its cards", async ({
page,
}) => {
await enableProjectsFeature(page);
await installMockBridge(page);
await page.goto("/", { waitUntil: "domcontentloaded" });
await page.getByTestId("open-projects-view").click();

await expect(page.getByTestId("projects-overview-panel")).toHaveCSS(
"background-color",
"rgba(0, 0, 0, 0)",
);

const stats = page.getByTestId("projects-overview-stat");
await expect(stats).toHaveCount(4);
for (let index = 0; index < 4; index += 1) {
await expect(stats.nth(index)).toHaveCSS(
"background-color",
"rgba(0, 0, 0, 0)",
);
await expect(stats.nth(index)).toHaveCSS("border-style", "solid");
}

const activityCards = page.getByTestId("projects-activity-card");
await expect(activityCards.first()).toBeVisible();
const activityCardCount = await activityCards.count();
for (let index = 0; index < activityCardCount; index += 1) {
await expect(activityCards.nth(index)).toHaveCSS(
"background-color",
"rgba(0, 0, 0, 0)",
);
await expect(activityCards.nth(index)).toHaveCSS("border-style", "solid");
}
});

test("project without a checkout offers fetch feedback and dropdown cloning", async ({
page,
}) => {
Expand Down
Loading