fix(desktop): clean up clicks and artifacts in all notification sounds - #3335
Open
joahg wants to merge 2 commits into
Open
fix(desktop): clean up clicks and artifacts in all notification sounds#3335joahg wants to merge 2 commits into
joahg wants to merge 2 commits into
Conversation
The default flutter notification sound had a full-spectrum click at onset, hard phase discontinuities between note segments, and broadband high-frequency hash — audible as crunch. Reprocessed the sample with de-clicking, a 9 kHz low-pass to remove the hash while keeping all harmonics, gentle onset/tail fades, and makeup gain so perceived loudness matches the original. Regenerated the waveform SVG. Amp-Thread-ID: https://ampcode.com/threads/T-019fa998-ed98-7793-84ca-4950ef2eb536 Co-authored-by: Amp <amp@ampcode.com> Signed-off-by: Joah Gerstenberg <joah@squareup.com>
joahg
marked this pull request as ready for review
July 28, 2026 16:47
…on sounds All 11 remaining notification sounds had audible clicks: every file started mid-waveform at high amplitude (onset pop, e.g. flirl at +0.57 full scale) and was hard-truncated at the file boundary while still audible (end click, -21 to -36 dBFS at the last 2ms). oh-no also decoded above full scale (+0.6 dBFS) and doong hit 0 dBFS. Applied the same treatment as flutter: de-click, 9 kHz low-pass, 60 Hz high-pass, 10 ms onset fade, tail fade-out, and per-file makeup gain so mean loudness matches each original. Peak-limited the four near-full- scale sounds to -0.8 dBFS. Regenerated waveform SVGs. Co-authored-by: Amp <amp@ampcode.com> Signed-off-by: Joah Gerstenberg <joah@squareup.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fa9ab-1c34-77cf-b69e-dc55b553c341
joahg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default notification sound (
flutter.mp3) sounded crunchy, and follow-up analysis found every one of the other 11 notification sounds had audible clicks at start and/or end.flutter — spectral analysis showed three culprits:
All 11 other sounds (bong, boo, dng, doo, doodone, doong, doop, flirl, oh-no, ping, unison):
oh-nodecodes above full scale (+0.6 dBFS);doonghits 0 dBFS;boo/doodone/unisonare within 0.2 dB of full scaleFix
Reprocessed all samples with the same ffmpeg chain:
adeclickto remove onset clicks and phase discontinuitiesRegenerated all waveform SVGs via
scripts/generate-sound-waveforms.mjs.Verified programmatically: all files now start at ~0 amplitude and end below −55 dBFS, with no sample-level discontinuities.
Tracking: AGNTOPS-339