Skip to content

fix(desktop): mention autocomplete drops every relay-directory agent before eligibility runs #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TNovs1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(desktop): mention autocomplete drops every relay-directory agent before eligibility runs #3292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion desktop/src/features/messages/lib/useMentions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
} from "@/features/channels/hooks";
import { useIsArchivedPredicate } from "@/features/identity-archive/hooks";
import type { MentionSuggestion } from "@/features/messages/ui/MentionAutocomplete";
import { mergeKnownAgentPubkeys } from "@/features/agents/knownAgentPubkeys";
import {
coalesceAgentAutocompleteCandidates,
coalesceAutocompleteCandidatesByKey,
Expand Down Expand Up @@ -221,6 +222,24 @@ export function useMentions(
return lookup;
}, [managedAgentsQuery.data, personasQuery.data]);
const knownAgentPubkeys = mentionableAgentPubkeys;
// Managed agents ∪ relay directory. `isAgentIdentityInManagedList` gates the
// autocomplete on THIS set, and passing only the managed agents makes every
// remotely-hosted agent unmentionable: the relay flags an attested identity
// `is_agent` (users.agent_owner_pubkey, write-once), the candidate therefore
// arrives with isAgent=true, and the gate drops it before
// `shouldHideAgentFromMentions` — so `relayAgentIsSharedWithUser`, the
// allowlist and channel membership are never consulted for it. That made the
// whole relay-agent branch of the eligibility module unreachable, including
// the relay-agent candidate loop below.
//
// The union is the set this app already treats as "known agents" everywhere
// else (`useKnownAgentPubkeys`, same `mergeKnownAgentPubkeys` helper); using
// it here restores the intended layering: identity/ownership decides who is
// KNOWN, and the eligibility rules decide who is INVOCABLE.
const knownOrManagedAgentPubkeys = React.useMemo(
() => mergeKnownAgentPubkeys(managedAgentsQuery.data, relayAgentsQuery.data),
[managedAgentsQuery.data, relayAgentsQuery.data],
);
const activePersonas = React.useMemo(
() => (personasQuery.data ?? []).filter((persona) => persona.isActive),
[personasQuery.data],
Expand All @@ -246,7 +265,7 @@ export function useMentions(
if (isArchivedDiscovery(pubkey)) {
return;
}
if (!isAgentIdentityInManagedList(candidate, managedAgentPubkeys)) {
if (!isAgentIdentityInManagedList(candidate, knownOrManagedAgentPubkeys)) {
return;
}
if (
Expand Down