Skip to content

fix(desktop): stop create-agent form clobbering provider config on keystroke #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IceRhymers wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(desktop): stop create-agent form clobbering provider config on keystroke #3220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion desktop/src/features/agents/ui/WhereToRunSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ export function WhereToRunSection({
setProbeError(null);
return;
}
// Once probed, don't re-probe: every keystroke in ProviderConfigFields
// produces a new `draft`, and re-running the probe would clobber the
// user's edits back to schema defaults. Switching providers resets the
// draft to emptyWhereToRunDraft (probedProvider: null), so a fresh probe
// still fires on provider change.
if (draft.probedProvider) return;
let cancelled = false;
setProbeError(null);
void probeBackendProvider(selectedBackendProvider.binaryPath)
Expand All @@ -50,7 +56,9 @@ export function WhereToRunSection({
onDraftChange({
...draft,
probedProvider: result,
providerConfig: defaults,
// Seed defaults without overwriting any values the user already
// typed, so a late-resolving probe can never erase input.
providerConfig: { ...defaults, ...draft.providerConfig },
});
})
.catch((error: unknown) => {
Expand Down
Loading