fix(desktop): ship poof sound as mp3 so Linux can decode it - #2804
fix(desktop): ship poof sound as mp3 so Linux can decode it#2804kwsantiago wants to merge 1 commit into
Conversation
Signed-off-by: Kyle 🐆 <kyle@privkey.io>
Chessing234
left a comment
There was a problem hiding this comment.
shipping plop as mp3 is the right linux decode fix — m4a was a footgun on gstreamer stacks (same family as #3488). please confirm the asset is re-encoded (not just renamed) and that mac/windows still play it; a one-line note in the pr about encoder settings helps reviewers who can't a/b the binary.
|
Confirmed re-encoded, not renamed. ffprobe on the committed blob: It begins with an ID3v2 tag rather than an MP4 Encoder settings are in the PR body: Mono and 44.1 kHz are carried over from the source. On macOS and Windows: I only have Linux hardware, so I did not test playback there. What I can say is that the app already ships mp3 for every other sound ( |
desktop/public/pow/plop.m4ais AAC. WebKitGTK decodes media through GStreamer, which has no AAC decoder in a default Linux install, so the poof sound never plays and startup logs:Every other bundled sound (
desktop/public/sounds/*.mp3) is already mp3, which decodes out of the box. This converts the one outlier.Re-encoded from the original asset with:
17264 -> 2826 bytes, mono 44.1 kHz preserved. The asset is MIT (Emerge Tools);
desktop/public/pow/LICENSE.txtis unchanged.Verification
Ubuntu 24.04, WebKitGTK 2.52.3, without
gstreamer1.0-libavinstalled:macOS and Windows are unaffected; their system webviews decode both formats.