fix(desktop): redeploy provider agents after config saves - #2799
Open
skyerus wants to merge 1 commit into
Open
Conversation
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
skyerus
force-pushed
the
codex/provider-config-redeploy
branch
from
July 25, 2026 01:26
871f4fd to
88b4bbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploypath after a provider-backed managed agent is explicitly savedCloses #2798.
Why
update_managed_agentcurrently persists the new provider config tomanaged-agents.json, but the external provider is never called. Desktop therefore shows the new model/config while the deployed agent continues using the previous values. Provider protocol v1 already defines repeateddeploycalls as idempotent update-in-place/no-op, so no shutdown protocol or UI lifecycle workaround is needed.Tests
cargo test --manifest-path desktop/src-tauri/Cargo.toml --lib --no-default-features explicit_save_redeploy_target_is_provider_backed_onlycargo test --manifest-path desktop/src-tauri/Cargo.toml --lib --no-default-features agent_modelscargo clippy --manifest-path desktop/src-tauri/Cargo.toml --lib --no-default-features(passes with four pre-existingsecret_store.rsdead-code warnings)cargo fmt --manifest-path desktop/src-tauri/Cargo.toml -- --checkgit diff --check