Skip to content

fix(desktop): redeploy provider agents after config saves - #2799

Open
skyerus wants to merge 1 commit into
block:mainfrom
skyerus:codex/provider-config-redeploy
Open

fix(desktop): redeploy provider agents after config saves#2799
skyerus wants to merge 1 commit into
block:mainfrom
skyerus:codex/provider-config-redeploy

Conversation

@skyerus

@skyerus skyerus commented Jul 25, 2026

Copy link
Copy Markdown

Summary

  • invoke the existing idempotent provider deploy path after a provider-backed managed agent is explicitly saved
  • leave local-agent behavior unchanged (runtime changes still apply on next spawn)
  • reload the managed-agent summary after deploy so provider metadata and errors are reflected in the UI
  • add regression coverage proving that only provider-backed records produce a redeploy target

Closes #2798.

Why

update_managed_agent currently persists the new provider config to managed-agents.json, but the external provider is never called. Desktop therefore shows the new model/config while the deployed agent continues using the previous values. Provider protocol v1 already defines repeated deploy calls as idempotent update-in-place/no-op, so no shutdown protocol or UI lifecycle workaround is needed.

Tests

  • cargo test --manifest-path desktop/src-tauri/Cargo.toml --lib --no-default-features explicit_save_redeploy_target_is_provider_backed_only
  • cargo test --manifest-path desktop/src-tauri/Cargo.toml --lib --no-default-features agent_models
  • cargo clippy --manifest-path desktop/src-tauri/Cargo.toml --lib --no-default-features (passes with four pre-existing secret_store.rs dead-code warnings)
  • cargo fmt --manifest-path desktop/src-tauri/Cargo.toml -- --check
  • git diff --check

@skyerus
skyerus requested a review from a team as a code owner July 25, 2026 01:21
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
skyerus force-pushed the codex/provider-config-redeploy branch from 871f4fd to 88b4bbf Compare July 25, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provider-backed agent config saves do not trigger redeployment

1 participant