Skip to content

fix(acp): anchor DM replies to thread root #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arisgysel-design wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −7
Open

fix(acp): anchor DM replies to thread root #2766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb804f0
fix(acp): anchor DM replies to thread root
arisgysel-design Jul 24, 2026
78feb58
Merge branch 'main' into PR #2766 to clear stale-base CI failure
Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions crates/buzz-acp/src/queue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1466,10 +1466,7 @@ pub fn format_prompt(batch: &FlushBatch, args: &FormatPromptArgs<'_>) -> Vec<Str
// there. DMs are always 1:1 with a human, so they always anchor.
let sender_pubkey = last_event.event.pubkey.to_hex();
let reply_anchor = if is_dm {
thread_tags
.root_event_id
.is_some()
.then(|| last_event.event.id.to_hex())
thread_tags.root_event_id.clone()
} else {
resolve_reply_anchor(
&sender_pubkey,
Expand Down Expand Up @@ -3907,9 +3904,13 @@ mod tests {
fn test_reply_instruction_present_for_dm_thread_reply() {
let ch = Uuid::new_v4();
let root_id = "b".repeat(64);
let parent_id = "c".repeat(64);
let event = make_event_with_tags(
"thanks",
vec![vec!["e".into(), root_id, "".into(), "reply".into()]],
vec![
vec!["e".into(), root_id.clone(), "".into(), "root".into()],
vec!["e".into(), parent_id.clone(), "".into(), "reply".into()],
],
);
let event_id = event.id.to_hex();
let batch = FlushBatch {
Expand All @@ -3936,8 +3937,16 @@ mod tests {
)
.join("\n\n");
assert!(
prompt.contains(&format!("--reply-to {event_id}")),
"DM thread reply should include reply instruction"
prompt.contains(&format!("--reply-to {root_id}")),
"DM thread reply should anchor to the thread root"
);
assert!(
!prompt.contains(&format!("--reply-to {event_id}")),
"DM thread reply should not anchor to the triggering event"
);
assert!(
!prompt.contains(&format!("--reply-to {parent_id}")),
"DM thread reply should not anchor to the parent event"
);
}

Expand Down
Loading