travis: make distdir#9390
Conversation
theuni
left a comment
theuni
left a comment
There was a problem hiding this comment.
fails in .17 sec, I assume it'll take < 1sec to pass. Looks good to me :)
| @@ -60,6 +60,7 @@ script: | |||
| - mkdir build && cd build | |||
| - ../configure $BITCOIN_CONFIG_ALL $BITCOIN_CONFIG || ( cat config.log && false) | |||
| - make $MAKEJOBS $GOAL || ( echo "Build failure. Verbose build follows." && make $GOAL V=1 ; false ) | |||
There was a problem hiding this comment.
Though, this requires calling configure twice, I assume...
There was a problem hiding this comment.
@MarcoFalke Yea, I don't think there's any way around configuring twice for that. There is a built-in that uses the cache to save some time, though.
Just change the:
make $MAKEJOBS check VERBOSE=1
to
make $MAKEJOBS distcheck VERBOSE=1
I think that should actually work these days.
There was a problem hiding this comment.
If this takes extra time, we could have only one of the builds do this. The distdir is arch-independent, after all.
There was a problem hiding this comment.
I think, if I change check to distcheck, it will compile twice, which is worse than configure twice?
|
Looks like it's taking just over 1 second on each build. |
Then it's not worth spending more time optimizing this, there's bigger fish to fry. Thanks for measuring. |
4 participants
@theuni This should be enough to get back the test, which was removed due to 142ffc7?
Edit: Also added an unrelated commit which removes a line in gitignore. (No longer needed, as the java comparision tool was removed)