Skip to content

docs: ci multi-arch requires qemu#29456

Merged
fanquake merged 1 commit into
bitcoin:masterfrom
m3dwards:ci-needs-qemu
Feb 21, 2024
Merged

docs: ci multi-arch requires qemu#29456
fanquake merged 1 commit into
bitcoin:masterfrom
m3dwards:ci-needs-qemu

Conversation

@m3dwards
Copy link
Copy Markdown
Contributor

On a fresh Debian system qemu isn't installed and therefore the multi-architecture CI system doesn't run.

This documentation notes that qemu is required and how to install it.

@DrahtBot
Copy link
Copy Markdown
Contributor

DrahtBot commented Feb 20, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK willcl-ark, maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Feb 20, 2024
@willcl-ark
Copy link
Copy Markdown
Member

willcl-ark commented Feb 21, 2024

Seems like a useful addition.

I do vaguely recall installing a binfmt package of some sort when I last did this, but could be misremembering something else I was doing with docker and qemu (apologies if so)...

edit: ah, seems like it comes with package Provides: qemu-user-binfmt.

Copy link
Copy Markdown
Member

@willcl-ark willcl-ark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 5402829

@maflcko
Copy link
Copy Markdown
Member

maflcko commented Feb 21, 2024

lgtm ACK 5402829

@fanquake fanquake merged commit 46d2616 into bitcoin:master Feb 21, 2024
@bitcoin bitcoin locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants