Skip to content

Implement a customizable tick rate to improve perf (closes #255).#258

Merged
bitbrain merged 6 commits into
bitbrain:godot-4.xfrom
lucasrafael98:variable-rate-tick
Dec 4, 2023
Merged

Implement a customizable tick rate to improve perf (closes #255).#258
bitbrain merged 6 commits into
bitbrain:godot-4.xfrom
lucasrafael98:variable-rate-tick

Conversation

@lucasrafael98

@lucasrafael98 lucasrafael98 commented Dec 2, 2023

Copy link
Copy Markdown
Contributor

Description

Simple implementation to solve #255 and greatly improve performance. The default remains at 1 because changing it is likely to break scripts that e.g. make agents move every tick.

edit closes #255

@lucasrafael98

Copy link
Copy Markdown
Contributor Author

Minor mistake, I think this should fix it.

@bitbrain

bitbrain commented Dec 3, 2023

Copy link
Copy Markdown
Owner

Could you add unit tests for this?

@lucasrafael98

Copy link
Copy Markdown
Contributor Author

Done, let me know if these are cool or if you need more. I also added reports/ to .gitignore but if that breaks e.g. CI I can rebase it out.

Comment thread runtest.sh

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. chmodded it to make it executable. Do you want to leave it non-executable?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind - my Github showed it as 'new empty file added'

Comment thread addons/beehave/nodes/beehave_tree.gd

@bitbrain bitbrain left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@bitbrain
bitbrain merged commit 8228d42 into bitbrain:godot-4.x Dec 4, 2023
@lucasrafael98
lucasrafael98 deleted the variable-rate-tick branch December 4, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] Variable rate tick()

2 participants