feat(promotions): PROMO-1507 add featured promotions callout to pdp and plp #3057
Open
bc-vivekaggarwal wants to merge 2 commits into
Open
feat(promotions): PROMO-1507 add featured promotions callout to pdp and plp #3057bc-vivekaggarwal wants to merge 2 commits into
bc-vivekaggarwal wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 76736d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
bc-vivekaggarwal
force-pushed
the
PROMO-1507-promotion-callout-plp-pdp
branch
from
587f0a7 to
a1c841d
Compare
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
bc-vivekaggarwal
force-pushed
the
PROMO-1507-promotion-callout-plp-pdp
branch
from
a1c841d to
7d235d4
Compare
bc-vivekaggarwal
force-pushed
the
PROMO-1507-promotion-callout-plp-pdp
branch
from
7d235d4 to
773bae3
Compare
bc-vivekaggarwal
force-pushed
the
PROMO-1507-promotion-callout-plp-pdp
branch
from
773bae3 to
3c11f1f
Compare
…nd plp using mock data
…n PDP and PLP pages
bc-vivekaggarwal
force-pushed
the
PROMO-1507-promotion-callout-plp-pdp
branch
from
3c11f1f to
76736d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: PROMO-1507
What/Why?
Adds a new
PromotionCalloutprimitive and wires promotion callouts into PDP and PLP pages.featuredPromotionson theProducttype.Rollout/Rollback
Revert.
Testing
testing notes / screenshots:
Migration
None.