Skip to content

Angular upgrade to v14#569

Merged
uldisrudzitis merged 3 commits intomasterfrom
enh-angular-upgrade-to-v14
Oct 1, 2025
Merged

Angular upgrade to v14#569
uldisrudzitis merged 3 commits intomasterfrom
enh-angular-upgrade-to-v14

Conversation

@uldisrudzitis
Copy link
Copy Markdown
Collaborator

@uldisrudzitis uldisrudzitis commented Oct 1, 2025

Summary by CodeRabbit

  • Chores
    • Upgraded Angular dependencies to v14 for improved compatibility and performance.
    • Updated TypeScript target to ES2020, enabling newer JavaScript features and potentially smaller bundles.
    • Adjusted workspace configuration by removing the default project, affecting CLI behavior when no project is specified.
    • Dropped Node 12 support; Node 14.15+ or 16.10+ is now required.

@uldisrudzitis uldisrudzitis self-assigned this Oct 1, 2025
@uldisrudzitis uldisrudzitis added Enhancement dependencies Pull requests that update a dependency file labels Oct 1, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 1, 2025

Walkthrough

Removed root "defaultProject" from editor/angular.json, upgraded Angular and related tooling to v14 and dropped Node 12 in editor/package.json, and raised TypeScript target/lib to ES2020 in editor/tsconfig.json. No source code or public API changes.

Changes

Cohort / File(s) Summary of changes
Angular workspace config
editor/angular.json
Removed root-level defaultProject entry; minor formatting adjustments.
Dependency and tooling upgrades
editor/package.json
Upgraded Angular packages and build/dev tooling to v14; bumped @types/node and adjusted engines to drop Node 12; aligned related dependencies (NGXS, editor libs) with Angular 14 ecosystem.
TypeScript compiler target
editor/tsconfig.json
Changed target from es2015 to es2020 and updated lib to es2020 + dom; other compilerOptions unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant CLI as ng CLI
  participant Config as editor/angular.json
  participant User as Developer

  rect rgba(120,180,200,0.12)
    Note over CLI,Config: Old flow (with defaultProject)
    CLI->>Config: read defaultProject
    Config-->>CLI: "berta" (default)
    CLI->>User: execute command against default project
  end

  rect rgba(200,160,120,0.12)
    Note over CLI,Config: New flow (defaultProject removed)
    CLI->>Config: read defaultProject
    Config-->>CLI: null / not present
    CLI->>User: request explicit --project or error
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

I hop through JSONs, twitching whiskers bright,
Removed the default, now commands ask "which site?"
ES2020 leaps, Node12 drifts away,
Packages bloom in a springtime array.
A rabbit’s small hop — configs tidy and light. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “Angular upgrade to v14” directly captures the primary change of upgrading the project’s Angular dependencies to version 14 and is concise and specific enough for a reviewer to understand the main intent of the pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch enh-angular-upgrade-to-v14

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ee5f52 and 6cb6955.

⛔ Files ignored due to path filters (1)
  • editor/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • editor/package.json (2 hunks)
  • editor/tsconfig.json (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
editor/angular.json (1)

1-122: Keep a default project or fix the CLI scripts.

Dropping defaultProject means commands like ng serve / ng build (used verbatim in package scripts) now fail with “Cannot determine project” because two projects exist (berta, berta-e2e). Restore the default or update every script to pass --project berta so basic workflows keep working.

   "projects": {
     "berta": {
       …
     }
   },
-  "defaultProject": "berta"
+  "defaultProject": "berta"
 }
🧹 Nitpick comments (2)
editor/tsconfig.json (1)

11-14: Align lib with new ES2020 target.

Raising target to ES2020 without updating "lib" keeps the compilation types capped at ES2018, so newer built-ins (e.g., Promise.allSettled, Array.prototype.at) remain untyped. Add the matching lib level to avoid missing type definitions.

-    "lib": ["es2018", "dom"]
+    "lib": ["es2020", "dom"]
editor/package.json (1)

52-52: Update Node typings to match the supported runtime.

With Node 12 dropped and engines now requiring ≥14, keeping @types/node frozen at 12.11.1 blocks newer APIs and mismatches the runtime. Bump the types (e.g., ^14.18.0 or ^16.18.0) so TS tooling reflects actual Node support.

-    "@types/node": "^12.11.1",
+    "@types/node": "^16.18.0",
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c32302a and 2ee5f52.

⛔ Files ignored due to path filters (1)
  • editor/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • editor/angular.json (1 hunks)
  • editor/package.json (2 hunks)
  • editor/tsconfig.json (1 hunks)

@uldisrudzitis uldisrudzitis merged commit 498813b into master Oct 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant