fix(llama-android): declare publish → sign task dependency (Gradle implicit-dependency validation)#313
Merged
Conversation
…alidation) The signed snapshot publish failed: Gradle 8's task-output validation rejected ':publishLlamaAndroidOpenclPublicationToCentralSnapshotsRepository' using the *.asc output of ':signLlamaAndroidPublication' without a declared dependency. Both publications (llamaAndroid / llamaAndroidOpencl) attach the SAME sourcesJar/javadocJar, so signing produces shared signature files that the *other* publication's publish task consumes. Fix (canonical maven-publish + signing multi-publication pattern): make every AbstractPublishToMaven task depend on every Sign task, so the ordering is explicit. No-op when signing is off (fork/PR runs without MAVEN_GPG_PRIVATE_KEY have no Sign tasks). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HTS5FpMtBLJENTGoRUrp5m
The b9941...b9947 range is 12 files (~100 KiB), dominated by Qualcomm Hexagon DSP + other ggml backend kernel code (upstream-compiled TUs, not in this project's classifier matrix). The only CPU-side patch-target file touched is common/arg.cpp, whose sole change is a .set_examples() metadata edit adding LLAMA_EXAMPLE_CLI to -of/--output-file — a different region than patch 0001's parse-function block. All eight patches apply unchanged; no project source changes required. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HTS5FpMtBLJENTGoRUrp5m
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
llama-androidAAR build: Gradle 8's task-output validation rejected:publishLlamaAndroidOpenclPublicationToCentralSnapshotsRepositoryfor using the*.ascoutput of:signLlamaAndroidPublication"without declaring an explicit or implicit dependency".
llamaAndroidCPU /llamaAndroidOpencl) attach the samesourcesJar+javadocJarinstances.
sign(publishing.publications)therefore signs those shared jars once, and the other publication's publish task readsthe resulting
.ascsignatures without an inferred task dependency — which Gradle flags.AbstractPublishToMaventask depend on everySigntask, so the ordering is explicit:MAVEN_GPG_PRIVATE_KEYhave noSigntasks), so it only affects thesigned publish paths.
Scope note: this is in the
llama-androidAAR publish path (the signed Central-Snapshots deploy), not in theandroid-llmserviceexample app. It surfaces only where signing actually runs (the GPG key is present) — which is why it appears on the
mainsnapshotpublish but not on PR/fork CI.
Test plan
MAVEN_GPG_PRIVATE_KEYsecret and thus runs on themainpush / publish jobs.tasks.withType<Sign>()is empty when no key is configured, so PR/fork CI is unaffected.Related issues / PRs
Surfaced on the
mainsnapshot-publish after the recent GPG signing-preflight work (#306–#309) wired signing through the Gradle pathfor
llama-android.Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.md🤖 Generated with Claude Code
https://claude.ai/code/session_01HTS5FpMtBLJENTGoRUrp5m
Generated by Claude Code