fix(android-llmservice): migrate Kotlin jvmTarget to compilerOptions DSL; Gradle 8.14.4; allowBackup=false#311
Merged
Conversation
…DSL; bump Gradle 8.14.4; allowBackup=false
CI build-android-llmservice failed at Gradle config: with Kotlin 2.4.0 the
android { kotlinOptions { jvmTarget = "17" } } string DSL is now a hard error.
- Migrate to the compilerOptions DSL: top-level kotlin { compilerOptions {
jvmTarget.set(JvmTarget.JVM_17) } } (import org.jetbrains.kotlin.gradle.dsl.JvmTarget).
- Bump the app CI job to Gradle 8.14.4 (clears the Kotlin-plugin deprecation warning for
Gradle < 8.14.4 and picks up two Gradle security fixes). AGP 8.7.3 stays; the AAR/lib
jobs remain on 8.14.3 (they use no Kotlin Gradle plugin, so are unaffected).
- allowBackup=false: resolves the CodeQL "Application backup allowed" alert and matches the
app's privacy promise — the saved session + copied model in filesDir stay out of adb/cloud backup.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HTS5FpMtBLJENTGoRUrp5m
bernardladenthin
had a problem deploying
to
startgate
GitHub Actions
Error
bernardladenthin
had a problem deploying
to
maven-central
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
GitHub Actions
Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-android-llmserviceCI failure. With Kotlin 2.4.0 theandroid { kotlinOptions { jvmTarget = "17" } }string DSL is now a hard error. Migrated to thecompilerOptionsDSL: a top-levelkotlin { compilerOptions { jvmTarget.set(JvmTarget.JVM_17) } }block (+import org.jetbrains.kotlin.gradle.dsl.JvmTarget).allowBackup=falsein the app manifest — resolves the CodeQL "Application backup allowed" alert and matches the app's privacy promise (the saved session + copied model infilesDirstay out of adb/cloud backup).Test plan
build-android-llmservice).Related issues / PRs
Refs #310 (introduced
android-llmservice; its merge-to-mainrun surfaced this build failure + the CodeQL alert).Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdallowBackup=falsechange is a public hardening (resolves a code-scanning alert), not a sensitive vulnerability requiring private disclosure.🤖 Generated with Claude Code
https://claude.ai/code/session_01HTS5FpMtBLJENTGoRUrp5m
Generated by Claude Code