This repository was archived by the owner on Aug 5, 2021. It is now read-only.
Move StopIteration.java to its correct directory for its package name#129
Merged
forman merged 1 commit intobcdev:masterfrom May 14, 2018
Merged
Move StopIteration.java to its correct directory for its package name#129forman merged 1 commit intobcdev:masterfrom
forman merged 1 commit intobcdev:masterfrom
Conversation
Member
|
@desruisseaux thanks, again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
StopIterationclass contains thepackage org.jpy;statement, but theStopIteration.javafile is wrongly located in theorg/jpy/annotationdirectory. Likely the package declaration is correct and the file location is wrong since this class is not an annotation. Furthermore theorg.jpypackage name is consistent with the call toJType_GetTypeForName(jenv, "org.jpy.StopIteration", JNI_FALSE)insrc/main/c/jpy_module.c