Fixes exception when passing incorrect bytes to decode

[ncordon]

An uncaught exception was thrown and python interpreter was killed because of that.

Closes #189

Signed-off-by: ncordon nacho.cordon.castillo@gmail.com

---

This change is 

[creachadair]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ncordon)

---

bblfsh/pyuast.cc, line 1060 at r1 (raw file):

      if (!pyU) {
        delete(ctx);
        return nullptr;

In this case we haven't released buf. Should we fall through as you did in the case below?

[ncordon]

---

bblfsh/pyuast.cc, line 1060 at r1 (raw file):

Previously, creachadair (M. J. Fromberger) wrote…

In this case we haven't released buf. Should we fall through as you did in the case below?

I think buf would be released after the try-catch, or am I missing something?

[creachadair]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ncordon)

---

bblfsh/pyuast.cc, line 1060 at r1 (raw file):

Previously, ncordon (Nacho Cordón) wrote…

I think buf would be released after the try-catch, or am I missing something?

I don't see how—if we return nullptr at this point control exits the function and that code never runs, right?

[ncordon]

---

bblfsh/pyuast.cc, line 1060 at r1 (raw file):

Previously, creachadair (M. J. Fromberger) wrote…

I don't see how—if we return nullptr at this point control exits the function and that code never runs, right?

Oh yes I missed that, my bad. Fixing it

[creachadair]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[dennwc]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[dennwc]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved

---

bblfsh/pyuast.cc, line 5 at r2 (raw file):

#include <cstring>
#include <unordered_map>
#include <iostream>

I was also wondering why it's there, but forgot to ask :)

[ncordon]

---

bblfsh/pyuast.cc, line 5 at r2 (raw file):

Previously, dennwc (Denys Smirnov) wrote…

I was also wondering why it's there, but forgot to ask :)

I erased it

[creachadair]

Reviewable status: complete! all files reviewed, all discussions resolved