Open
Conversation
added 7 commits
September 16, 2019 12:46
Contributor
You might want to check this change against this issue #159 (which is the reason why it was initially separated into its own component) see #160 for more details. TL;DR: using react inspector tool |
Contributor
Author
Contributor
Author
|
facebook/react#16437 (comment) The original highlighting function has disappeared but instead you can use the profiler to record the rendering. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Is your Pull Request request related to another issue in this repository ?
Not from this issue, but DPE has a dependency on react-transcript-editor and we want to start adding tests to it.
bbc/digital-paper-edit-electron#4
Describe what the PR does
Adding the most basic test to timed-text-editor and also removing CustomEditor because it's a wrapper component for one single function - we don't really need it.
State whether the PR is ready for review or whether it needs extra work
Ready
Additional context