Merged
Conversation
Contributor
Author
|
Checks fail as example output of speechmatics adapter is changed, will provide new ground truth. |
…g values, which resulted in wrong speaker assignment in some cases
…r name instead of end-of-sentence symbols.
murezzda
force-pushed
the
speechmatics-adapter-update
branch
from
ff8bf60 to
10a87b7
Compare
emettely
approved these changes
Sep 24, 2019
Contributor
emettely
left a comment
emettely
left a comment
There was a problem hiding this comment.
The changes look fine to me :)
I’m not too across how speechmatics works, but the only bits that I think could be buggy is if the element.time doesn't exist for whatever reason, and you get a NaN after running float(element.time). I imagine this doesn't happen very often.
Contributor
|
Apologies @murezzda, @jamesdools pointed out: I meant to merge, but I closed it 🤦♂ |
Contributor
Author
|
Hi @emettely, thanks for the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
No
Describe what the PR does
The speechmatics STT-adapter is updated with the following points:
A new paragraph is created when the speaker changes
or
when the word count of a single speaker paragraph exeeds 150 words and a sentence is finished (indicated by .?!)
State whether the PR is ready for review or whether it needs extra work
Ready for review.