storybook, npm, webpack setup - draft#184
Merged
Conversation
pietrop
changed the title
allishultes
approved these changes
Aug 15, 2019
allishultes
left a comment
allishultes
left a comment
There was a problem hiding this comment.
Looks good overall - I haven't tried to set it up but have left a few comments. There's some editing (spelling, grammar) I'd do too but this is ultimately clear.
This was referenced Aug 15, 2019
emettely
suggested changes
Aug 20, 2019
Contributor
emettely
left a comment
emettely
left a comment
There was a problem hiding this comment.
If you are going to mention historical changes, you would need to describe it more - not much how and why, so when you mention babel I'm a bit puzzled as to why you mention it.
emettely
approved these changes
Aug 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
mostly based on #135 but also related to #130, #129
Describe what the PR does
Based on PR #135 provides a guide for setting up storybook with npm to publish components. Drafted for
bbc/digital-paper-edit-storybooksetup.State whether the PR is ready for review or whether it needs extra work
Ready for review by @jamesdools @emettely
cc @allishultes
Additional context
NA
Just a draft, see if it makes sense, and feel free, to change/clarify. It be good to capture this setup if we are going to re-use in DPE etc..