Merged
Conversation
pietrop
force-pushed
the
storybook-addons
branch
from
697ac8d to
9008d1b
Compare
jamesdools
approved these changes
Apr 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
Following from #130 and note about storybook addons from Modularization + storybook release - project board
Describe what the PR does
Played around with adding storybook add ons, to evaluate which one are worth adding, and which one just introduce clutter
State whether the PR is ready for review or whether it needs extra work
Ready for review, not ready for merge, need to support for
knobsto all of the components.Additional context
added
@storybook/addon-knobs@storybook/addon-viewport@storybook/addon-a11yMaking component accessible #126Still deciding on
@storybook/addon-info@storybook/addon-jeststorybook-addon-i18n-toolsAlso still thinking about best way to move QA doc into storybook,
perhaps going through the QA doc and adding more stories per component using the QA example could be a good way? altho some of the QA items could also translate into tests.