Skip to content

Add build_script_env_files crate annotation - #4166

Merged
UebelAndre merged 1 commit into
bazelbuild:mainfrom
finn-ball:finn/build-script-env
Jul 31, 2026
Merged

Add build_script_env_files crate annotation#4166
UebelAndre merged 1 commit into
bazelbuild:mainfrom
finn-ball:finn/build-script-env

Conversation

@finn-ball

Copy link
Copy Markdown
Contributor

Summary

Add build_script_env_files support to crate.annotation, allowing environment files to be passed to generated cargo_build_script targets.

The change:

  • Exposes build_script_env_files through bzlmod and legacy crate annotations.
  • Propagates the annotation through crate-universe configuration and build-script context.
  • Renders the attribute on generated cargo_build_script rules.
  • Supports unconditional and platform-selected values.
  • Updates the configuration digest.
  • Adds tests for annotation propagation and BUILD-file rendering.

Testing

  • bazel test //crate_universe:unit_test

@UebelAndre UebelAndre left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The change looks good but has a merge conflict.

@finn-ball
finn-ball force-pushed the finn/build-script-env branch 9 times, most recently from 311a094 to 7b48ec4 Compare July 31, 2026 11:56
@finn-ball
finn-ball force-pushed the finn/build-script-env branch from 7b48ec4 to f83eb63 Compare July 31, 2026 12:03
@UebelAndre
UebelAndre added this pull request to the merge queue Jul 31, 2026
Merged via the queue into bazelbuild:main with commit d7c7117 Jul 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants