Handle PIC/NOPIC correctly in establish_cc_info - #4131
Merged
Conversation
krasimirgg
self-requested a review
July 7, 2026 09:14
krasimirgg
enabled auto-merge
July 7, 2026 09:34
auto-merge was automatically disabled
July 7, 2026 09:37
Head branch was pushed to by a user without write access
This change determines whether to use pic_static_library or static_library in cc_common.create_library_to_link based on the should_use_pic helper. It also updates the unit tests to expect only one of the libraries depending on the configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change determines whether to use
pic_static_libraryorstatic_libraryincc_common.create_library_to_linkbased on theshould_use_pichelper. It also updates the unit tests to expect only one of the libraries depending on the configuration.