Fix coverage for crates with mixed sources - #4106
Merged
Merged
Conversation
UebelAndre
marked this pull request as ready for review
June 25, 2026 17:19
UebelAndre
enabled auto-merge
June 25, 2026 17:22
illicitonion
approved these changes
Jun 25, 2026
slackito
added a commit
to slackito/rules_rust
that referenced
this pull request
Jul 8, 2026
This allows callers of rustc_compile_action to override the default flags. The motivating example for making this change was some path remapping done by Crubit (https://github.com/google/crubit/blob/main/rs_bindings_from_cc/bazel_support/compile_rust.bzl#L100). PR bazelbuild#4106 added another `--remap-path-prefix` flag after the code that adds `rust_flags` to the rustc invocation, and the new remapping took precedence.
patrickmscott
pushed a commit
to patrickmscott/rules_rust
that referenced
this pull request
Jul 13, 2026
…n. (bazelbuild#4135) This allows callers of rustc_compile_action to override the default flags. The motivating example for making this change was some path remapping done by Crubit (https://github.com/google/crubit/blob/685a46aabbdf6552803c5bd77da6628008d0d245/rs_bindings_from_cc/bazel_support/compile_rust.bzl#L100). PR bazelbuild#4106 added another `--remap-path-prefix` flag after the code that adds `rust_flags` to the rustc invocation, and the new remapping took precedence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An expansion of #4079 with some added testing.
closes #4079