feature: introduce link_deps attribute for native library linkage - #4024
Merged
Conversation
krasimirgg
self-requested a review
May 8, 2026 13:37
krasimirgg
requested changes
May 11, 2026
Suyashagarw
force-pushed
the
link-deps
branch
2 times, most recently
from
May 13, 2026 20:17
0812abf to
6ffe12e
Compare
krasimirgg
reviewed
May 18, 2026
Suyashagarw
force-pushed
the
link-deps
branch
3 times, most recently
from
May 18, 2026 19:27
092f8e4 to
2d62bd3
Compare
krasimirgg
self-requested a review
May 19, 2026 09:07
krasimirgg
enabled auto-merge
May 19, 2026 09:08
auto-merge was automatically disabled
May 19, 2026 15:39
Head branch was pushed to by a user without write access
Suyashagarw
force-pushed
the
link-deps
branch
2 times, most recently
from
May 25, 2026 10:17
2324978 to
812181b
Compare
krasimirgg
enabled auto-merge
May 28, 2026 08:50
This change adds a dedicated link_deps attribute to Rust rules, allowing native symbols to be linked without exposing them as Rust crates. Key changes: - Added link_deps to _common_attrs for CcInfo/CrateInfo targets. - Filtered link_deps out of rust_proc_macro to avoid transition complexity. - Implemented transform_link_deps to extract linkage context while hiding crate metadata. - Added a proactive warning for native libraries incorrectly listed in deps. - Added unit tests in test/unit/link_deps to verify correct linkage.
auto-merge was automatically disabled
June 1, 2026 11:29
Head branch was pushed to by a user without write access
krasimirgg
enabled auto-merge
June 1, 2026 12:33
Collaborator
|
@krasimirgg @Suyashagarw per #4095
I did notice this change added tons of debug prints to builds in |
UebelAndre
pushed a commit
to UebelAndre/rules_rust
that referenced
this pull request
Jun 23, 2026
bazelbuild#4024 introduced a warning for targets adding CC deps in `deps`. The warning calls out putting this in `link_deps` or `cc_deps`. The latter makes more sense here... but doesn't actually exist. However, I don't think this matters anyways, as I don't think it's needed (this works with an internal codebase).
Collaborator
Hey, missed that. Internally, we have some customizations that add the |
sync-agent-neo Bot
pushed a commit
to aosp-mirror-neo/platform_external_bazelbuild-rules_rust
that referenced
this pull request
Jun 24, 2026
A follow-up from bazelbuild/rules_rust#4024 where we inadvertently mentioned a feature that doesn't exist.
slackito
pushed a commit
to slackito/rules_rust
that referenced
this pull request
Jun 26, 2026
bazelbuild#4024 now adds noisy prints that users have no way to handle when using crate_universe. This change adds annotations so the prints can be actioned.
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Jun 26, 2026
### What does this PR do? Move `:cpp_stdlib` out of the shared `_LIB_DEPS` and into `link_deps` on the `dd-procmgrd-lib` and `dd-procmgrd-lib-testhelpers` targets. ### Motivation `rules_rust` 0.71.0 deprecates C++ libraries in a Rust target's `deps` and adds `link_deps` for manual FFI linkage: - bazelbuild/rules_rust#4024. Left in `deps`, `:cpp_stdlib` makes the build emit a deprecation warning per target: ``` WARNING: Target @@//pkg/procmgr/rust:cpp_stdlib in 'deps' of @@//pkg/procmgr/rust:dd-procmgrd-lib-testhelpers is a C++ library. Only Rust targets are allowed in 'deps'. Please use 'link_deps' for manual FFI linkage. Support for C++ libraries in 'deps' is deprecated and will be removed in a future release. WARNING: Target @@//pkg/procmgr/rust:cpp_stdlib in 'deps' of @@//pkg/procmgr/rust:dd-procmgrd-lib is a C++ library. Only Rust targets are allowed in 'deps'. Please use 'link_deps' for manual FFI linkage. Support for C++ libraries in 'deps' is deprecated and will be removed in a future release. ``` ### Describe how you validated your changes `bazel build //pkg/procmgr/rust:dd-procmgrd` links cleanly with no `cpp_stdlib` deprecation warning, confirming the `-lstdc++` linkage still propagates to the binary through `link_deps`. ### Additional Notes Will anyway ease the transition to `rules_rs`, backed by `rules_rust`. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a dedicated link_deps attribute to Rust rules, allowing native symbols to be linked without exposing them as Rust crates.
Closes #4023
Key changes:
This provides a cleaner separation of concerns between Rust modules and native code linkage while maintaining full backward compatibility for existing targets.