Support escaped runfile paths - #3910
Conversation
|
Rebased: 54b3d78a9 -> 14e2faeb9 |
|
CI fails for |
|
Seems like you unfortunately hit bazelbuild/continuous-integration#1838 If you run |
|
Coverage succeeds locally. |
|
I opened bazelbuild/continuous-integration#2508 but in the mean time you could update the presubmit file for this job to add |
Add support for spaces, newlines and backslashes in paths written to the runfiles MANIFEST file.
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Thanks! Just one request!
| .ok_or(RunfilesError::RunfilesManifestInvalidFormat)?; | ||
| Ok::<(PathBuf, PathBuf), RunfilesError>((pair.0.into(), pair.1.into())) | ||
| let pair = if line.starts_with(' ') { | ||
| // Unescape according to src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java. |
There was a problem hiding this comment.
Can you leave a link with a commit hash in it so the context isn't invalidated by upstream changes when folks go to look this up?
| // Unescape according to src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java. | |
| // Unescape according to SourceManifestAction.java | |
| // https://github.com/bazelbuild/bazel/blob/5b3e143adf7ccf40b05f73b0711f60f1ceade180/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java |
There was a problem hiding this comment.
I choose a link with line numbers as well. Thank you for the review!
|
Looks like CI failed with a network flake 😞 If you push a new commit (e.g. |
3 participants
Add support for spaces, newlines and backslashes in paths written to the runfiles MANIFEST file.