Delete "dummy" wasm cc_toolchain - #3892
Merged
Merged
Conversation
UebelAndre
marked this pull request as ready for review
March 7, 2026 13:41
UebelAndre
force-pushed
the
dummy
branch
6 times, most recently
from
March 7, 2026 20:59
efc2c8b to
830754c
Compare
PiotrSikora
approved these changes
Mar 9, 2026
PiotrSikora
left a comment
PiotrSikora
left a comment
Contributor
There was a problem hiding this comment.
I didn't look at the changes, but I've tested this PR with proxy-wasm-rust-sdk and it allows us to remove dummy toolchains from MODULE.bazel. Thanks!
UebelAndre
enabled auto-merge
March 10, 2026 18:36
UebelAndre
commented
Mar 11, 2026
illicitonion
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #3665 there should no longer be a need to register a fake cc_toolchain to target wasm platforms.
closes #1601