Include *.rmeta files in stdlib sysroot glob - #3860
Merged
Merged
Conversation
Starting around nightly 2026-01-22, the Rust distribution ships stdlib .rlib files as metadata stubs, with the full metadata in separate .rmeta files. Add *.rmeta to the _build_file_for_stdlib_template glob so these files are included in the Bazel sysroot. Fixes bazelbuild#3859
krasimirgg
self-requested a review
February 23, 2026 09:33
krasimirgg
enabled auto-merge
February 23, 2026 09:33
wfraser
pushed a commit
to dropbox/rules_rust
that referenced
this pull request
Apr 2, 2026
Starting around nightly `2026-01-22` (rustc 1.95.0-nightly), the Rust distribution ships stdlib `.rlib` files as ~440-byte metadata stubs, with full metadata in separate `.rmeta` files alongside them. The [`_build_file_for_stdlib_template`](https://github.com/bazelbuild/rules_rust/blob/42b098b3a891d7425212c39697e436a21fb5399e/rust/private/repository_utils.bzl#L275) glob [only includes `*.rlib`](https://github.com/bazelbuild/rules_rust/blob/42b098b3a891d7425212c39697e436a21fb5399e/rust/private/repository_utils.bzl#L280-L286), so the `.rmeta` files are excluded from the sysroot, causing `error[E0786]: only metadata stub found` errors. This PR adds `*.rmeta` to the glob. Fixes bazelbuild#3859 Co-authored-by: Krasimir Georgiev <krasimir@google.com> (cherry picked from commit 5f633d2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting around nightly
2026-01-22(rustc 1.95.0-nightly), the Rust distribution ships stdlib.rlibfiles as ~440-byte metadata stubs, with full metadata in separate.rmetafiles alongside them. The_build_file_for_stdlib_templateglob only includes*.rlib, so the.rmetafiles are excluded from the sysroot, causingerror[E0786]: only metadata stub founderrors.This PR adds
*.rmetato the glob.Fixes #3859