fix: Return repo_metadata from repository rules in rust/repositories.bzl - #3855
Merged
illicitonion merged 1 commit intoFeb 19, 2026
Merged
Conversation
mortenmj
force-pushed
the
mmj/rust-toolchain-tools-reproducible
branch
from
February 14, 2026 16:07
1c52b2d to
28fd5cb
Compare
mortenmj
force-pushed
the
mmj/rust-toolchain-tools-reproducible
branch
from
February 18, 2026 22:28
28fd5cb to
b857d5d
Compare
illicitonion
approved these changes
Feb 19, 2026
illicitonion
left a comment
Collaborator
There was a problem hiding this comment.
Looks reasonable, thanks!
dzbarsky
pushed a commit
to hermeticbuild/rules_rust
that referenced
this pull request
Feb 20, 2026
…bzl (bazelbuild#3855) This allows repos produced by `rust_toolchain_tools_repository` to use the remote repo content cache. Using Bazel 9.0.0 and the remote repo content cache, the external directory in the output base is much smaller when using this patch. Downloading the toolchain, which comes in at almost 800 MB, can be entirely skipped when using remote execution. Before: ```shell external # du -h -d1 | sort -h | grep rules_rust <SNIP> 4.0K ./rules_rust++i+rules_rust_tinyjson 32K ./rules_rust++rust+rust_toolchains 196K ./rules_rust_prost+ 6.1M ./rules_rust+ 787M ./rules_rust++rust+rust_linux_x86_64__x86_64-unknown-linux-gnu__stable_tools ``` After: ```shell external # du -h -d1 | sort -h | grep rules_rust <SNIP> 4.0K ./rules_rust++i+rules_rust_tinyjson 4.0K ./rules_rust++rust+rust_linux_x86_64__x86_64-unknown-linux-gnu__stable_tools 32K ./rules_rust++rust+rust_toolchains 196K ./rules_rust_prost+ 6.1M ./rules_rust+ ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows repos produced by
rust_toolchain_tools_repositoryto use the remote repo content cache.Using Bazel 9.0.0 and the remote repo content cache, the external directory in the output base is much smaller when using this patch. Downloading the toolchain, which comes in at almost 800 MB, can be entirely skipped when using remote execution.
Before:
After: