[3844] Use rootpath for wrapper root for determinism - #3845
Merged
Conversation
katre
reviewed
Feb 5, 2026
| edition = "2018", | ||
| rustc_env = { | ||
| "WRAPPED_TOOL_EXECPATH": "$(execpath {})".format(target), | ||
| "WRAPPED_TOOL_EXECPATH": "$(rootpath {})".format(target), |
Contributor
There was a problem hiding this comment.
Should the variable (here and in main.rs) also be changed? It looks like this is just a fallback for finding the binary when runfiles fails.
Contributor
Author
There was a problem hiding this comment.
Potentially this "fix" could break cross compilation potentially if the target is different to the execution host?
Contributor
Author
There was a problem hiding this comment.
I'm open to ideas on other fixes
illicitonion
force-pushed
the
finn/wrapper-determinism
branch
from
February 6, 2026 18:14
5c99129 to
f08b1da
Compare
illicitonion
approved these changes
Feb 6, 2026
illicitonion
left a comment
illicitonion
left a comment
Collaborator
There was a problem hiding this comment.
Looks reasonable to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3844
Uses a relative path instead of absolute: