Fixes behavior of rust_generated_srcs within the rust-analyzer aspect - #3836
Merged
Conversation
csmulhern
changed the title
csmulhern
force-pushed
the
main
branch
4 times, most recently
from
February 3, 2026 23:17
7e7a8bb to
d38664b
Compare
Contributor
Author
|
@UebelAndre is there someone that can take a look at this? |
Contributor
Author
|
@UebelAndre this is up to date again if there's someone who can take a look. |
UebelAndre
approved these changes
May 4, 2026
UebelAndre
left a comment
UebelAndre
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the ping! This looks great!
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing rust analyzer aspect does not handle generated files completely.
srcsattribute, so on a top level target that uses a generated dependency, the aspect will not run.rust_generated_srcsis not aggregated onto the top-level target, the files themselves will not be generated. This breaks things like e.g. jump-to-definition if you try to jump to a file that has not yet been generated by bazel.This PR addresses both these issues.