Write lockfile external only - #3699
Merged
illicitonion merged 8 commits intoNov 10, 2025
Merged
Conversation
hofbi
force-pushed
the
write-lockfile-external-only
branch
2 times, most recently
from
October 29, 2025 17:17
32e534d to
6873aac
Compare
hofbi
marked this pull request as ready for review
October 29, 2025 17:18
illicitonion
left a comment
Collaborator
There was a problem hiding this comment.
This looks great to me, thank you! Just two small testing addition suggestions :)
hofbi
force-pushed
the
write-lockfile-external-only
branch
from
November 9, 2025 15:14
31e88f2 to
45cf1d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Another attempt to improve #3522
Current status/plan on the issue above was
Cargo.lockfile into aCargo.bazel.lockfile by removing internal depscrate.from_cargowith theCargo.bazel.lockfile andskip_cargo_lockfile_overwrite = TrueMODULE.bazel.lockwhich should have less merge conflicts since the sha ofCargo.bazel.lockdoes not change that oftenThis works, but we need to make sure
Cargo.lockis up to date. This requires another step, so we replace a slow automated step (cargo splicing) with an extra manual/non-bazel step (updating theCargo.lockfile).New idea to iterate
crate.from_cargowith theCargo.bazel.lockfile but instead of usingskip_cargo_lockfile_overwrite = Truestrip_internal_dependencies_from_cargo_lockfileflagThis would save us the pre-commit hook as well as the manual step to update the
Cargo.lockfile. I already did a quick verification andremove_internal_dependencies_from_cargo_lockfileachieves the same results as the python implementation I listed in #3522Open Points
This is an early draft to collect feedback. Once we aligned how exactly we want to proceed, I would like to