Skip to content

Fix infra logging being dropped in certain cases #748

@n8kim1

Description

@n8kim1

Possibly related to #749

In IAP 2024, during the initial deployment setup, things failed. We didn't have logs for this, which was very odd and slowing. Later, we continued to not see logs in some cases.

It's hard to find a concrete cause, so fixing this entirely may be difficult. DWBI if tricky

From Jerry:

meanwhile an issue for infra: why did it fail so badly? there’s an explicit log line wrapping the git clone
I suspect the reason is as simple as two things:
I think the git package we’re importing is silent-failing when the clone fails. I can’t think of any other explanation to the error.
The fmt.Errorf error is only logged to gcloud and we forgot to log.Ctx(ctx).Error().Err(err).Msgf("Error: %v", err) --
there is a log line but I think it logs to the wrong place, ie not to the stream directed toward database

Also:
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageNew or unclassified issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions