fix: split README check into PR-comment + main-update jobs#241
Draft
Paveltarno wants to merge 4 commits intomainfrom
Draft
fix: split README check into PR-comment + main-update jobs#241Paveltarno wants to merge 4 commits intomainfrom
Paveltarno wants to merge 4 commits intomainfrom
Conversation
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/cli@0.0.32-pr.241.887699fPrefer not to change any import paths? Install using npm alias so your code still imports npm i "base44@npm:@base44-preview/cli@0.0.32-pr.241.887699f"Or add it to your {
"dependencies": {
"base44": "npm:@base44-preview/cli@0.0.32-pr.241.887699f"
}
}
Preview published to npm registry — try new features instantly! |
a0dc09b to
f9f3953
Compare
|
README check ran. README is up to date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Description
This PR fixes a critical bug in the token refresh mechanism where request bodies were being consumed during retry attempts, causing API calls to fail after 401 responses. The fix clones the request before retrying to preserve the original request body. Additionally, comprehensive test coverage has been added to verify the token refresh behavior works correctly for different API endpoints.
Related Issue
None
Type of Change
Changes Made
base44-client.tsby cloning requests before retry to prevent request body consumptiontests/cli/authorization.spec.ts) covering:Testing
npm test)Checklist
Additional Notes
The bug occurred because
kyinternally preserves the original request for retries, but when we passed the request to a nestedky()call without cloning, the nested call would consume the request body (vianew Request(request, init)). This left the outer ky's preserved request in an unusable state if the inner call failed and outer ky attempted its own retry. Cloning the request ensures each layer maintains its own independent copy.🤖 Generated by Claude | 2026-02-16 12:15 UTC